linux-kernel - Re: [PATCH] checkpatch: Remove cvs keyword check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83b27d29bc19f146f7fdfede24786ef01076fcd3.camel@perches.com>
Date:   Wed, 27 Oct 2021 02:21:50 -0700
From:   Joe Perches <joe@...ches.com>
To:     Kari Argillander <kari.argillander@...il.com>
Cc:     apw@...onical.com, dwaipayanray1@...il.com,
        lukas.bulwahn@...il.com, linux-kernel@...r.kernel.org,
        ntfs3@...ts.linux.dev
Subject: Re: [PATCH] checkpatch: Remove cvs keyword check

On Wed, 2021-10-27 at 10:35 +0300, Kari Argillander wrote:
> On Tue, Oct 26, 2021 at 05:26:21PM -0700, Joe Perches wrote:
> > On Wed, 2021-10-27 at 02:16 +0300, Kari Argillander wrote:
> > > Time has pass and we do not need these anymore as almost all people are
> > > using git now days. Those who use cvs for kernel development probably
> > > will handle cvs pretty well already so this check is not needed anymore.
> > 
> > I think it's a relatively harmless thing to keep.
> > 
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > []
> > > @@ -4017,12 +4017,6 @@ sub process {
> > >  			}
> > >  		}
> > >  
> > > -# check for RCS/CVS revision markers
> > > -		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
> > 
> > Looks like this would be better using
> > 
> > 		if ($rawline =~ /^\+.*\b\$(?:Revision|Log|Id)\$?\b/) {
> As I say before I do not know much about cvs or perl regex, but I do not
> get any match with your suggestion

Meh.  The regex doesn't like the \b before and after the $

This seems better:
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 1784921c645da..40552da610019 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4063,7 +4063,7 @@ sub process {
 		}
 
 # check for RCS/CVS revision markers
-		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
+		if ($rawline =~ /^\+.*\$(?:Revision|Log|Id)(?::.*)?\$/) {
 			WARN("CVS_KEYWORD",
 			     "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
 		}