linux-kernel - Re: [PATCH] fs: reiserfs: free new_opts in reiserfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211027111527.GD28650@quack2.suse.cz>
Date:   Wed, 27 Oct 2021 13:15:27 +0200
From:   Jan Kara <jack@...e.cz>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Jan Kara <jack@...e.cz>, Yu Kuai <yukuai3@...wei.com>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        David Howells <dhowells@...hat.com>,
        reiserfs-devel@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: reiserfs: free new_opts in reiserfs_remount

On Wed 27-10-21 18:19:00, Dongliang Mu wrote:
> On Wed, Oct 27, 2021 at 5:46 PM Jan Kara <jack@...e.cz> wrote:
> >
> > On Wed 27-10-21 11:39:25, Dongliang Mu wrote:
> > > Since the commit c3d98ea08291 ("VFS: Don't use save/replace_mount_options
> > > if not using generic_show_options") eliminates replace_mount_options
> > > in reiserfs, but did not handle the allocated new_opts,
> > > it will cause memory leak in the reiserfs_remount.
> > >
> > > Fix this by freeing new_opts in the reiserfs_remount temporarily.
> > >
> > > Fixes: c3d98ea08291 ("VFS: Don't use save/replace_mount_options if not using generic_show_options")
> > > Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> >
> > Thanks for the patch but I can see that new_opts is not actually used at
> > all in reiserfs_remount() so we should perhaps just remove them (including
> > kstrdup() et al).
> 
> That's also a plan. Since I am not sure if maintainers will use
> new_opts anymore, So I propose a temporary patch to fix this memory
> leak.
> 
> If you think new_opts is not used anymore, let's remove all the code
> related to new_opts.

If it is ever needed again, we can always add it. Please just remove it.
Thanks!

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR