linux-kernel - Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d243edae-9d3d-1a00-3dcd-c4c2d1fb02cd@redhat.com>
Date:   Wed, 27 Oct 2021 15:36:14 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Jani Nikula <jani.nikula@...ux.intel.com>
Cc:     Daniel Vetter <daniel@...ll.ch>, Kees Cook <keescook@...omium.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...ux.ie>, Arnd Bergmann <arnd@...db.de>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency

On 10/27/21 15:25, Arnd Bergmann wrote:

[snip]

> That's not going to help in this case, the way the helper functions work is that
> you select them as needed, and you avoid the other dependencies. This part
> works fine.
> 
> We could probably get rid of this symbol by just making it an unconditional
> part of drm.ko, as almost every driver ends up using it anyway.
> 
> Arguably, this would make the end result worse, as you'd again get drm.ko
> itself to link against the old framebuffer code.
> 
> What I'm not sure about is whether drivers/video/fbdev/core/fb.ko could
> be split up into smaller parts so DRM_FBDEV_EMULATION could
> only depend on a set of common code without the bits that are needed
> for the classic fbdev drivers.
>

I attempted to do something like that but the changes were nacked:

https://patchwork.kernel.org/project/linux-fbdev/list/?series=538227
 
>       Arnd
> 

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat