linux-kernel - Re: [PATCH 2/2] dt-bindings: Migrate DA9063 text bindings to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 09:12:28 -0500
From:   Rob Herring <robh@...nel.org>
To:     Alexandre Ghiti <alexandre.ghiti@...onical.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Lee Jones <lee.jones@...aro.org>, linux-rtc@...r.kernel.org,
        linux-input@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-watchdog@...r.kernel.org,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Guenter Roeck <linux@...ck-us.net>, devicetree@...r.kernel.org,
        Support Opensource <support.opensource@...semi.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 2/2] dt-bindings: Migrate DA9063 text bindings to YAML

On Wed, 27 Oct 2021 07:23:23 +0200, Alexandre Ghiti wrote:
> DA9063 devices bindings used text format, so migrate those bindings to YAML
> format before adding any new bindings.
> 
> Signed-off-by: Alexandre Ghiti <alexandre.ghiti@...onical.com>
> ---
>  .../bindings/input/da9063-onkey.yaml          |  39 ++++++
>  .../devicetree/bindings/mfd/da9063.txt        | 111 ------------------
>  .../devicetree/bindings/mfd/da9063.yaml       |  98 ++++++++++++++++
>  .../bindings/regulator/da9063-regulator.yaml  |  51 ++++++++
>  .../devicetree/bindings/rtc/da9063-rtc.yaml   |  31 +++++
>  .../bindings/watchdog/da9063-watchdog.yaml    |  31 +++++
>  6 files changed, 250 insertions(+), 111 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/da9063-onkey.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
>  create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
>  create mode 100644 Documentation/devicetree/bindings/regulator/da9063-regulator.yaml
>  create mode 100644 Documentation/devicetree/bindings/rtc/da9063-rtc.yaml
>  create mode 100644 Documentation/devicetree/bindings/watchdog/da9063-watchdog.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/mfd/da9063.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/mfd/da9063.yaml:27:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/mfd/da9063.example.dts:21.17-18 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1441: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/input/da9062-onkey.txt: Documentation/devicetree/bindings/mfd/da9063.txt

See https://patchwork.ozlabs.org/patch/1546751

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.