linux-kernel - Re: touchscreen_dmi.c Patch for Viglen Connect 10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d14456e0-9df3-7239-7598-9181cf807215@redhat.com>
Date:   Wed, 27 Oct 2021 16:13:49 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Mark Stamp <stamp497@...glemail.com>
Cc:     linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: touchscreen_dmi.c Patch for Viglen Connect 10

Hi Mark,

On 10/27/21 04:11, Mark Stamp wrote:
> Hello. 
> 
> I previously spoke with you on a touchscreen issue
> 
> https://github.com/onitake/gsl-firmware/issues/178
> 
> With regard to that, I made a patch for touchscreen_dmi.c. It adds
> parameters for the Viglen Connect 10 tablet to get its touchscreen and
> home button working.
> 
> Signed-off-by: Mark Stamp <stamp497@...glemail.com>

Thank you for your patch.

Unfortunately your email program has wrapped some long lines:

> 
> --- touchscreen_dmi.c.orig	2021-10-27 01:26:47.842668712 +0100
> +++ touchscreen_dmi.c	2021-10-27 01:27:06.426298127 +0100
> @@ -938,6 +938,26 @@ static const struct ts_dmi_data trekstor
>  	.properties	= trekstor_surftab_wintron70_props,
>  };
>  
> +static const struct property_entry viglen_connect_10_props[] = {
> +	//PROPERTY_ENTRY_U32("touchscreen-min-x", 20),
> +	PROPERTY_ENTRY_U32("touchscreen-min-x", 0),
> +	PROPERTY_ENTRY_U32("touchscreen-min-y", 0),
> +	PROPERTY_ENTRY_U32("touchscreen-size-x", 1890),
> +	PROPERTY_ENTRY_U32("touchscreen-size-y", 1280),
> +	PROPERTY_ENTRY_U32("touchscrken-fuzz-x", 8),
> +	PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 6),
> +	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> +	PROPERTY_ENTRY_STRING("firmware-name", "gsl3680-viglen-
> connect-10.fw"),
> +	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> +	PROPERTY_ENTRY_BOOL("silead,home-button"),
> +	{ }
> +};
> +
> +static const struct ts_dmi_data viglen_connect_10_data = {
> +	.acpi_name	= "MSSL1680:00",
> +	.properties	= viglen_connect_10_props,
> +};
> +
>  static const struct property_entry vinga_twizzle_j116_props[] = {
>  	PROPERTY_ENTRY_U32("touchscreen-size-x", 1920),
>  	PROPERTY_ENTRY_U32("touchscreen-size-y", 1280),
> @@ -1522,6 +1542,14 @@ const struct dmi_system_id touchscreen_d
>  		},
>  	},
>  	{
> +		/* Viglen Connect 10 */
> +		.driver_data = (void *)&viglen_connect_10_data,
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Viglen Ltd."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Connect 10''
> Tablet PC"),

And at least for this line I'm not sure how to unwrap it (does there
need to be a space there or not ?).


> +		},
> +	},
> +	{
>  		/* Vinga Twizzle J116 */
>  		.driver_data = (void *)&vinga_twizzle_j116_data,
>  		.matches = {
> 
> 


Can you resend this using git send-email (preferred), or send the
diff as attachment instead of inlining it?

Regards,

Hans