linux-kernel - Re: [PATCH v3 02/16] objtool: Explicitly avoid self modifying code in .altinstr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211028040105.evz2inkbb7647ytr@treble>
Date:   Wed, 27 Oct 2021 21:01:05 -0700
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, andrew.cooper3@...rix.com,
        linux-kernel@...r.kernel.org, alexei.starovoitov@...il.com,
        ndesaulniers@...gle.com, bpf@...r.kernel.org
Subject: Re: [PATCH v3 02/16] objtool: Explicitly avoid self modifying code
 in .altinstr_replacement

On Tue, Oct 26, 2021 at 02:01:34PM +0200, Peter Zijlstra wrote:
> +	/*
> +	 * Alternative replacement code is just template code which is
> +	 * sometimes copied to the original instruction, For now, don't

s/,/./

> +	 * annotate it. (In the future we might consider annotating the
> +	 * original instruction if/when it ever makes sense to do so.).

s/\.$//

> +	 */

-- 
Josh