linux-kernel - Re: [PATCH] staging: comedi: Cleaned a bit of code that was not required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YXozqK1elRwpK0qf@kroah.com>
Date:   Thu, 28 Oct 2021 07:22:48 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     vaatsalya shrivastava <shrivastavavaatsalya@...il.com>
Cc:     manohar.vanga@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: Cleaned a bit of code that was not
 required

On Wed, Oct 27, 2021 at 03:32:34PM -0400, vaatsalya shrivastava wrote:
> Warning found by checkpatch.pl script.

Please be specific as to what you did.

> 
> Signed-off-by: vaatsalya shrivastava <shrivastavavaatsalya@...il.com>

"V" and "S"?

> ---
>  drivers/comedi/drivers/dt2815.c        | 2 +-
>  drivers/staging/vme/devices/vme_user.h | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/comedi/drivers/dt2815.c b/drivers/comedi/drivers/dt2815.c
> index 5906f32aa01f..2be240630bbd 100644
> --- a/drivers/comedi/drivers/dt2815.c
> +++ b/drivers/comedi/drivers/dt2815.c
> @@ -17,7 +17,7 @@
>   * contrary, please update.
>   *
>   * Configuration options:
> - * [0] - I/O port base base address
> + * [0] - I/O port base address

The original is correct.

>   * [1] - IRQ (unused)
>   * [2] - Voltage unipolar/bipolar configuration
>   *	0 == unipolar 5V  (0V -- +5V)
> diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme/devices/vme_user.h
> index 19ecb05781cc..3c1564fd9b20 100644
> --- a/drivers/staging/vme/devices/vme_user.h
> +++ b/drivers/staging/vme/devices/vme_user.h

This is not a comedi driver.

> @@ -14,11 +14,11 @@ struct vme_master {
>  	__u32 aspace;		/* Address Space */
>  	__u32 cycle;		/* Cycle properties */
>  	__u32 dwidth;		/* Maximum Data Width */
> -#if 0
> +

You can not just remove these lines, please realize what you are doing.

thanks,

greg k-h