linux-kernel - Re: [PATCH v3 2/6] drm/msm/dp: Add DP controllers for sc7280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n53gO-NtWosw8kjTkjv7eUPt+VH2rzAvDAYYwpGK+jJ=nw@mail.gmail.com>
Date:   Wed, 27 Oct 2021 23:21:13 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Sankeerth Billakanti <quic_sbillaka@...cinc.com>,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     robdclark@...il.com, seanpaul@...omium.org,
        kalyan_t@...eaurora.org, abhinavk@...eaurora.org,
        dianders@...omium.org, khsieh@...eaurora.org,
        mkrishn@...eaurora.org, sbillaka@...eaurora.org
Subject: Re: [PATCH v3 2/6] drm/msm/dp: Add DP controllers for sc7280

Quoting Sankeerth Billakanti (2021-10-27 18:54:44)
> The eDP controller on SC7280 is similar to the eDP/DP controllers
> supported by the current driver implementation.
>
> SC7280 supports one EDP and one DP controller which can operate
> concurrently.
>
> This change adds the support for eDP and DP controller on sc7280.
>
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@...cinc.com>
>
> changes in v3:
>     - Split into patches according to function (Dmitry Baryshkov)
>     - Use DP_CONTROLLER_1 for eDP controller intf (Dmitry Baryshkov)
>     - Use DP_CONTROLLER_0 for sc7280-dp (Dmitry Baryshkov)
>     - Add macro in drm_helper.h for checking ssc capability (Stephen Boyd)
>     - Use existing macro to check assr capability (Stephen Boyd)
>     - Add comment for HPD_INIT_SETUP delay (Stephen Boyd)
>
> changes in v2:
>     - Don't initialize variables to 0 (Stephen Boyd)
>     - Use const for read-only dpcd (Stephen Boyd)
>     - Remove zero pixel clock check (Stephen Boyd)
>     - Sort compatible strings alphabetically (Stephen Boyd)
>     - Use pwm_bl.c for backlight instead of gpio (Stephen Boyd)
>     - Change return type for functions returning always 0 (Matthias Kaehlcke)
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>