linux-kernel - [linux-next][PATCH] media: stm32-dma2d: fix compile-testing failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 28 Oct 2021 14:40:20 +0800
From:   Dillon Min <dillon.minfei@...il.com>
To:     mchehab@...nel.org, hverkuil-cisco@...all.nl
Cc:     acourbot@...omium.org, arnd@...db.de, stanimir.varbanov@...aro.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: [linux-next][PATCH] media: stm32-dma2d: fix compile-testing failed

get compile-test failed report from lkp@...el.com after the driver
submitted.

"ld.lld: error: undefined symbol: v4l2_fh_init"

so, make CONFIG_STM32_DMA2D depends on CONFIG_VIDEO_DEV and
CONFIG_VIDEO_V4L2 to fix this compile error.

Fixes: bdbbd511ef0c ("media: stm32-dma2d: STM32 DMA2D driver")
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Dillon Min <dillon.minfei@...il.com>
---
Hi Hans

I found the dma2d driver was merged to linux-next.
so submit this patch based on linux-next/master, to fix the compile test error.

hope it's not too late for 5.16.

Thanks & Best Regards
Dillon

 drivers/media/platform/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 68f16aef8754..9fbdba0fd1e7 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -494,7 +494,8 @@ endif # VIDEO_STI_DELTA
 
 config VIDEO_STM32_DMA2D
 	tristate "STM32 Chrom-Art Accelerator (DMA2D)"
-	depends on (VIDEO_DEV && VIDEO_V4L2 && ARCH_STM32) || COMPILE_TEST
+	depends on VIDEO_DEV && VIDEO_V4L2
+	depends on ARCH_STM32 || COMPILE_TEST
 	select VIDEOBUF2_DMA_CONTIG
 	select V4L2_MEM2MEM_DEV
 	help
-- 
2.25.1