linux-kernel - RE: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB867600CAD244395B2AF2E8A08C869@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date:   Thu, 28 Oct 2021 06:48:37 +0000
From:   Richard Zhu <hongxing.zhu@....com>
To:     Francesco Dolcini <francesco.dolcini@...adex.com>
CC:     Mark Brown <broonie@...nel.org>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never
 came up

> -----Original Message-----
> From: Francesco Dolcini <francesco.dolcini@...adex.com>
> Sent: Tuesday, October 26, 2021 5:49 PM
> To: Richard Zhu <hongxing.zhu@....com>
> Cc: Francesco Dolcini <francesco.dolcini@...adex.com>; Mark Brown
> <broonie@...nel.org>; l.stach@...gutronix.de; bhelgaas@...gle.com;
> lorenzo.pieralisi@....com; jingoohan1@...il.com;
> linux-pci@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de
> Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link
> never came up
> 
> On Tue, Oct 26, 2021 at 09:18:39AM +0000, Richard Zhu wrote:
> > > Isn't this something that depend on the actual board design? From
> > > the driver point of view you should not silently enforce such design
> > > requirement on the board.
> > > Am I missing something here? Would be glad to you if you can clarify
> in case.
> > >
> > [Richard Zhu] Yes, it is relied on the actual HW board design.
> > This regulator is one optional, not mandatory required for all the board
> designs.
> > So, there is one _enabled or not check before manipulate this regulator.
> I think I was not clear in my question.
> 
> I'm asking what's is going to happen if the vpci-e supply is used in the
> actual board design AND the same regulator is shared with another
> device (to my understanding this should be just fine from the regulator API
> point of view, correct me if I'm wrong).
[Richard Zhu] Yes, agree with you. 
It should be fine from the regulator API point of view.
BR
Richard

> 
> I'm not talking about board designed by NXP in which such use case might
> not exist.
> 
> Francesco