linux-kernel - Re: [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <361311a6-5818-6fc8-56d9-1a0ab8eaa74b@gmail.com>
Date:   Wed, 27 Oct 2021 19:05:22 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] of/unittest: Disable new dtc node_name_vs_property_name
 and interrupt_map warnings

On 10/26/21 5:55 PM, Rob Herring wrote:
> The unittest dtbs have various intentional errors which cause warnings.
> With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
> some new checks: node_name_vs_property_name and interrupt_map warnings.
> 
> These warnings are also generated for static_base_1.dtb, so let's just
> disable the problematic warnings for all unittest dtbs instead of just
> testcases.dtb.
> 
> Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Frank Rowand <frowand.list@...il.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/of/unittest-data/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
> index a5d2d9254b2c..7e1a25ad4e5c 100644
> --- a/drivers/of/unittest-data/Makefile
> +++ b/drivers/of/unittest-data/Makefile
> @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
>  DTC_FLAGS_testcases += -@
>  
>  # suppress warnings about intentional errors
> -DTC_FLAGS_testcases += -Wno-interrupts_property
> +DTC_FLAGS += -Wno-interrupts_property \
> +	-Wno-node_name_vs_property_name \
> +	-Wno-interrupt_map
>  
>  # Apply overlays statically with fdtoverlay.  This is a build time test that
>  # the overlays can be applied successfully by fdtoverlay.  This does not
> 

Before applying this commit, I am not seeing the warning that -Wno-interrupt_map
suppresses.  I've tried with (1) CONFIG_OF_DYNAMIC and (2) with both
CONFIG_OF_DYNAMIC and CONFIG_OF_OVERLAY, and I don't see the warning.

Where are you seeing the interrupt_map warning?

I would prefer not changing from DTC_FLAGS_testcases to DTC_FLAGS because
the suppresses the warning for all unittest .dts files, not just the two
that lead to the node_name_vs_property_name warning. These two cases can
be covered with DTC_FLAGS_testcases and DTC_FLAGS_static_test_1.

-Frank