linux-kernel - Re: [PATCH v2 1/3] ath10k: fix division by zero in send path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163540646648.24978.9801837945005945514.kvalo@codeaurora.org>
Date:   Thu, 28 Oct 2021 07:34:31 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Amitkumar Karwar <amitkarwar@...il.com>,
        Ganapathi Bhat <ganapathi017@...il.com>,
        Sharvari Harisangam <sharvari.harisangam@....com>,
        Xinming Hu <huxinming820@...il.com>,
        Brian Norris <briannorris@...omium.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Johan Hovold <johan@...nel.org>, stable@...r.kernel.org,
        Erik Stromdahl <erik.stromdahl@...il.com>
Subject: Re: [PATCH v2 1/3] ath10k: fix division by zero in send path

Johan Hovold <johan@...nel.org> wrote:

> Add the missing endpoint max-packet sanity check to probe() to avoid
> division by zero in ath10k_usb_hif_tx_sg() in case a malicious device
> has broken descriptors (or when doing descriptor fuzz testing).
> 
> Note that USB core will reject URBs submitted for endpoints with zero
> wMaxPacketSize but that drivers doing packet-size calculations still
> need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
> endpoint descriptors with maxpacket=0")).
> 
> Fixes: 4db66499df91 ("ath10k: add initial USB support")
> Cc: stable@...r.kernel.org      # 4.14
> Cc: Erik Stromdahl <erik.stromdahl@...il.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

2 patches applied to ath-next branch of ath.git, thanks.

a006acb93131 ath10k: fix division by zero in send path
c1b9ca365dea ath6kl: fix division by zero in send path

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211027080819.6675-2-johan@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches