linux-kernel - Re: [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YXpjEeeajd706Nak@hovoldconsulting.com>
Date:   Thu, 28 Oct 2021 10:45:05 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Anssi Hannula <anssi.hannula@...wise.fi>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description

On Wed, Oct 27, 2021 at 01:21:24PM +0300, Anssi Hannula wrote:
> TTY_DRIVER_REAL_RAW flag (which is always set for e.g. serial ports)
> documentation says that driver must always set special character
> handling flags in certain conditions.
> 
> However, as the following sentence makes clear, what is actually
> intended is the opposite.
> 
> Fix that by removing the unintended double negation.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@...wise.fi>
> ---

Acked-by: Johan Hovold <johan@...nel.org>

> This one seems to have been there since 1994.
> 
>  include/linux/tty_driver.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
> index c20431d8def8..5bec04481c60 100644
> --- a/include/linux/tty_driver.h
> +++ b/include/linux/tty_driver.h
> @@ -360,7 +360,7 @@ static inline void tty_set_operations(struct tty_driver *driver,
>   * 	Used for PTY's, in particular.
>   * 
>   * TTY_DRIVER_REAL_RAW --- if set, indicates that the driver will
> - * 	guarantee never not to set any special character handling
> + * 	guarantee never to set any special character handling
>   * 	flags if ((IGNBRK || (!BRKINT && !PARMRK)) && (IGNPAR ||
>   * 	!INPCK)).  That is, if there is no reason for the driver to
>   * 	send notifications of parity and break characters up to the