linux-kernel - Re: [PATCH] Drivers: hv : vmbus: Adding NULL pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211028114233.nebhfxgait6qy2xa@liuwe-devbox-debian-v2>
Date:   Thu, 28 Oct 2021 11:42:33 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     cgel.zte@...il.com
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, decui@...rosoft.com,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lv Ruyi <lv.ruyi@....com.cn>, Zeal Robot <zealci@....com.cn>,
        Tianyu.Lan@...rosoft.com
Subject: Re: [PATCH] Drivers: hv : vmbus: Adding NULL pointer check

On Thu, Oct 28, 2021 at 10:41:38AM +0000, cgel.zte@...il.com wrote:
> From: Lv Ruyi <lv.ruyi@....com.cn>
> 
> This patch fixes the following Coccinelle warning:
> drivers/hv/ring_buffer.c:223: alloc with no test
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
> ---
>  drivers/hv/ring_buffer.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
> index 931802ae985c..4ef5c3771079 100644
> --- a/drivers/hv/ring_buffer.c
> +++ b/drivers/hv/ring_buffer.c
> @@ -223,6 +223,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
>  		pages_wraparound = kcalloc(page_cnt * 2 - 1,
>  					   sizeof(struct page *),
>  					   GFP_KERNEL);
> +		if (!pages_wraparound)
> +			return -ENOMEM;
>  

(CC Tianyu)

This hunk appears to have been mistakenly deleted by Tianyu's IVM patch
set.

Thanks for noticing this.

Applied to hyperv-next. No "fixes@ tag needed here.

Wei.

>  		pages_wraparound[0] = pages;
>  		for (i = 0; i < 2 * (page_cnt - 1); i++)
> -- 
> 2.25.1
>