linux-kernel - Re: [PATCH net 1/7] net: hns3: fix pause config problem after autoneg disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41ed2a6f-b9fc-4806-72d1-1e65f946fe30@huawei.com>
Date:   Thu, 28 Oct 2021 21:14:01 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <wangjie125@...wei.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao288@...ilicon.com>
Subject: Re: [PATCH net 1/7] net: hns3: fix pause config problem after autoneg
 disabled



On 2021/10/28 20:30, Andrew Lunn wrote:
>> Hi Andrew, thanks very much for your guidance on how to use pause autoneg,
>> it confuses me before because PHY registers actually have no separate setting
>> bit of pause autoneg.
>>
>> So, summarize what you mean:
>> 1. If pause autoneg is on, driver should always use the autoneg result to program
>>     the MAC. Eventhough general autoneg is off now and link state is no changed then
>>     driver just needs to keep the last configuration for the MAC, if link state is
>>     changed and phy goes down and up then driver needs to program the MAC according
>>     to the autoneg result in the link_adjust callback.
>> 2. If pause autoneg is off, driver should directly configure the MAC with tx pause
>>     and rx pause. Eventhough general autoneg is on, driver should ignore the autoneg
>>     result.
>>
>> Do I understand right?
> 
> Yes, that fits my understanding of ethtool, etc.
> 
> phylink tried to clear up some of these problems by fully implementing
> the call within phylink. All the MAC driver needs to provide is a
> method to configure the MAC pause settings. Take a look at
> phylink_ethtool_set_pauseparam() and the commit messages related to
> that.
> 
> 	Andrew
> .
> 
Ok, thanks!