linux-kernel - Re: [PATCH 0/3] Add FDMA support on ocelot switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211028140738.4mozxpgltezu6zsm@skbuf>
Date:   Thu, 28 Oct 2021 14:07:39 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Clément Léger <clement.leger@...tlin.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] Add FDMA support on ocelot switch driver

On Thu, Oct 28, 2021 at 03:49:29PM +0200, Clément Léger wrote:
> This series adds support for the Frame DMA present on the VSC7514
> switch. The FDMA is able to extract and inject packets on the various
> ethernet interfaces present on the switch.
> 
> While adding FDMA support, bindings were switched from .txt to .yaml
> and mac address read from device-tree was added to allow be set instead
> of using random mac address.
> 
> Clément Léger (3):
>   net: ocelot: add support to get mac from device-tree
>   dt-bindings: net: convert mscc,vsc7514-switch bindings to yaml
>   net: ocelot: add FDMA support
> 
>  .../bindings/net/mscc,vsc7514-switch.yaml     | 183 ++++
>  .../devicetree/bindings/net/mscc-ocelot.txt   |  83 --
>  drivers/net/ethernet/mscc/Makefile            |   1 +
>  drivers/net/ethernet/mscc/ocelot.h            |   2 +
>  drivers/net/ethernet/mscc/ocelot_fdma.c       | 811 ++++++++++++++++++
>  drivers/net/ethernet/mscc/ocelot_fdma.h       |  60 ++
>  drivers/net/ethernet/mscc/ocelot_net.c        |  30 +-
>  drivers/net/ethernet/mscc/ocelot_vsc7514.c    |  20 +-
>  include/linux/dsa/ocelot.h                    |  40 +-
>  include/soc/mscc/ocelot.h                     |   2 +
>  10 files changed, 1140 insertions(+), 92 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/mscc-ocelot.txt
>  create mode 100644 drivers/net/ethernet/mscc/ocelot_fdma.c
>  create mode 100644 drivers/net/ethernet/mscc/ocelot_fdma.h
> 
> -- 
> 2.33.0
>

Oh yes, finally some care and attention for the ocelot switchdev driver.
I'll review this soon, but I can't today.
Will you be keeping the hardware for some extended period of time, and
do you have some other changes planned as well?