linux-kernel - Re: [PATCH v2 1/3] iio: add adddac subdirectory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211028170256.5a616bae@jic23-huawei>
Date:   Thu, 28 Oct 2021 17:02:56 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cosmin Tanislav <demonsingur@...il.com>
Cc:     cosmin.tanislav@...log.com, Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] iio: add adddac subdirectory

On Thu, 28 Oct 2021 16:56:03 +0300
Cosmin Tanislav <demonsingur@...il.com> wrote:

> From: Cosmin Tanislav <cosmin.tanislav@...log.com>
> 
> For IIO devices that expose both ADC and DAC functionality.
> 
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@...log.com>
Why v2?

Should be a change log (+ I would suggest a cover letter).
Also, reply to previous version if there haven't been comments that
you are replying to..

I'll assume most v1 comments apply to v2 and hence wait for v3.

Please leave some time for others to review these versions before
sending a v3.  

Jonathan

> ---
>  drivers/iio/Kconfig        | 1 +
>  drivers/iio/Makefile       | 1 +
>  drivers/iio/addac/Kconfig  | 8 ++++++++
>  drivers/iio/addac/Makefile | 6 ++++++
>  4 files changed, 16 insertions(+)
>  create mode 100644 drivers/iio/addac/Kconfig
>  create mode 100644 drivers/iio/addac/Makefile
> 
> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
> index 2334ad249b46..4fb4321a72cb 100644
> --- a/drivers/iio/Kconfig
> +++ b/drivers/iio/Kconfig
> @@ -70,6 +70,7 @@ config IIO_TRIGGERED_EVENT
>  
>  source "drivers/iio/accel/Kconfig"
>  source "drivers/iio/adc/Kconfig"
> +source "drivers/iio/addac/Kconfig"
>  source "drivers/iio/afe/Kconfig"
>  source "drivers/iio/amplifiers/Kconfig"
>  source "drivers/iio/cdc/Kconfig"
> diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile
> index 65e39bd4f934..8d48c70fee4d 100644
> --- a/drivers/iio/Makefile
> +++ b/drivers/iio/Makefile
> @@ -15,6 +15,7 @@ obj-$(CONFIG_IIO_TRIGGERED_EVENT) += industrialio-triggered-event.o
>  
>  obj-y += accel/
>  obj-y += adc/
> +obj-y += addac/
>  obj-y += afe/
>  obj-y += amplifiers/
>  obj-y += buffer/
> diff --git a/drivers/iio/addac/Kconfig b/drivers/iio/addac/Kconfig
> new file mode 100644
> index 000000000000..2e64d7755d5e
> --- /dev/null
> +++ b/drivers/iio/addac/Kconfig
> @@ -0,0 +1,8 @@
> +#
> +# ADC DAC drivers
> +#
> +# When adding new entries keep the list in alphabetical order
> +
> +menu "Analog to digital and digital to analog converters"
> +
> +endmenu
> diff --git a/drivers/iio/addac/Makefile b/drivers/iio/addac/Makefile
> new file mode 100644
> index 000000000000..b888b9ee12da
> --- /dev/null
> +++ b/drivers/iio/addac/Makefile
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Makefile for industrial I/O ADDAC drivers
> +#
> +
> +# When adding new entries keep the list in alphabetical order