linux-kernel - Re: [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Oct 2021 19:00:49 +0300
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org
Cc:     Henrik Bjoernlund <henrik.bjoernlund@...rochip.com>,
        Roopa Prabhu <roopa@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        "moderated list:ETHERNET BRIDGE" <bridge@...ts.linux-foundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] net: bridge: fix uninitialized variables when
 BRIDGE_CFM is disabled

On 28/10/2021 18:58, Ivan Vecera wrote:
> Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
> that return a count. When BRIDGE_CFM is not enabled these functions
> simply return -EOPNOTSUPP but do not modify count parameter and
> calling function then works with uninitialized variables.
> Modify these inline functions to return zero in count parameter.
> 
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Cc: Henrik Bjoernlund <henrik.bjoernlund@...rochip.com>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---
>  net/bridge/br_private.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 37ca76406f1e..fd5e7e74573c 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1911,11 +1911,13 @@ static inline int br_cfm_status_fill_info(struct sk_buff *skb,
>  
>  static inline int br_cfm_mep_count(struct net_bridge *br, u32 *count)
>  {
> +	*count = 0;
>  	return -EOPNOTSUPP;
>  }
>  
>  static inline int br_cfm_peer_mep_count(struct net_bridge *br, u32 *count)
>  {
> +	*count = 0;
>  	return -EOPNOTSUPP;
>  }
>  #endif
> 

Thank you,
Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>