linux-kernel - Re: [PATCH] HID: hid-asus.c: Maps key 0x35 (display off) to KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKdAkRTdCSC_6UqWkcT3p697+d0kwEqMSSR=M9vw-NPAjdZ4SQ@mail.gmail.com>
Date:   Thu, 28 Oct 2021 09:07:25 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Vinícius Angiolucci Reis <itsme.vreis@...il.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, angiolucci@...il.com
Subject: Re: [PATCH] HID: hid-asus.c: Maps key 0x35 (display off) to KEY_SCREENLOCK

Hi Vinícius,

On Fri, Oct 8, 2021 at 3:24 PM Vinícius Angiolucci Reis
<itsme.vreis@...il.com> wrote:
>
> On Windows systems, ASUS laptops uses the "turn display off" key
> (usually fn+f6) to turn both display and keyboard backlit off. On Linux
> systems, this key has no effect at all since most desktop enviroments
> don't deal with KEY_DISPLAY_OFF. By mapping it to KEY_SCREENLOCK
> instead, would enable desktop environments to handle this key as a
> screen lock intent from the user, out of the box.

But is it the intent of the user? The fact that current desktop
environments do not handle this key is not a reason to change kernel
behavior.

If screen lock is simply your preference then you can change the
mapping via udev on your system without the need to patch the kernel.

Thanks.

--
Dmitry