linux-kernel - Re: [PATCH] Staging: greybus: audio_codec: changed a void function to return 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211028163534.mpoimdxtdirlsbmn@h510>
Date:   Thu, 28 Oct 2021 12:35:34 -0400
From:   Bryan Brattlof <hello@...anbrattlof.com>
To:     Senthu Sivarajah <ssivaraj@...d.fra-uas.de>
Cc:     vaibhav.sr@...il.com, greybus-dev@...ts.linaro.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: greybus: audio_codec: changed a void function
 to return 0

Hi Senthu,

On this day, October 28, 2021, thus sayeth Senthu Sivarajah:
> From: Senthuran Sivarajah <ssivaraj@...d.fra-uas.de>
> 
> Fixed a coding style issue.
> 
> Signed-off-by: Senthuran Sivarajah <ssivaraj@...d.fra-uas.de>
> 
> ---
>  drivers/staging/greybus/audio_codec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6b1d03..9f99862791dc 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -1028,7 +1028,7 @@ static int gbcodec_probe(struct snd_soc_component *comp)
>  static void gbcodec_remove(struct snd_soc_component *comp)
	  ^^^^

If I'm not mistaken here, our options are to remove the return or just 
leave this as is. IMO I think this is fine as is.

~Bryan