linux-kernel - Re: [PATCH] scsi: ufs: Fix proper API to send HPB pre-request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YXrZgC7mYVQS+CE6@infradead.org>
Date:   Thu, 28 Oct 2021 10:10:24 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        James Bottomley <jejb@...ux.ibm.com>, daejun7.park@...sung.com,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "huobean@...il.com" <huobean@...il.com>,
        Keoseong Park <keosung.park@...sung.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: Fix proper API to send HPB pre-request

On Thu, Oct 28, 2021 at 10:07:52AM -0700, Bart Van Assche wrote:
> I spent some time looking around for other examples of allocating and
> inserting a request from inside block layer callbacks. I only found one
> such example, namely in the NVMe core. nvme_timeout() calls
> nvme_alloc_request() and blk_execute_rq_nowait(). The difference between
> what the UFS HPB code is doing and what nvme_timeout() does doesn't seem
> that big to me.

The difference is that nvme_timeout allocates a request on the
admin queue, and only does so for commands on the I/O queues.