linux-kernel - Re: [PATCH] drm/bridge: sn65dsi86: ti_sn65dsi86_read_u16() __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG3jFyuxsJ_bWppw=2K0dTxheqDdVuFwojka8VMZH_p9Fmo4FA@mail.gmail.com>
Date:   Thu, 28 Oct 2021 19:12:58 +0200
From:   Robert Foss <robert.foss@...aro.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drm/bridge: sn65dsi86: ti_sn65dsi86_read_u16() __maybe_unused

Hey Bjorn,

Thanks for fixing this quickly.

On Thu, 28 Oct 2021 at 18:33, Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
>
> When built without CONFIG_PWM there are no references to
> ti_sn65dsi86_read_u16(), avoid the W=1 build warning by marking the
> function as __maybe_unused.
>
> __maybe_unused is used insted of a #ifdef guard as it looks slighly
> cleaner and it avoids issues if in the future other permutations of the
> config options would use the function.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>
> Robert, I believe you pushed out the driver patch introducing this issue
> yesterday. Can you please add the relevant Fixes?

Added fixes & r-b tags.

Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip")
Reviewed-by: Robert Foss <robert.foss@...aro.org>

Applied to drm-misc-next

>
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 430067a3071c..e1f43b73155b 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -215,8 +215,8 @@ static const struct regmap_config ti_sn65dsi86_regmap_config = {
>         .cache_type = REGCACHE_NONE,
>  };
>
> -static int ti_sn65dsi86_read_u16(struct ti_sn65dsi86 *pdata,
> -                                unsigned int reg, u16 *val)
> +static int __maybe_unused ti_sn65dsi86_read_u16(struct ti_sn65dsi86 *pdata,
> +                                               unsigned int reg, u16 *val)
>  {
>         u8 buf[2];
>         int ret;
> --
> 2.33.1
>