lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Oct 2021 10:57:46 -0700 From: Peter Gonda <pgonda@...gle.com> To: thomas.lendacky@....com Cc: Peter Gonda <pgonda@...gle.com>, David Rientjes <rientjes@...gle.com>, Brijesh Singh <brijesh.singh@....com>, Marc Orr <marcorr@...gle.com>, Joerg Roedel <jroedel@...e.de>, Herbert Xu <herbert@...dor.apana.org.au>, John Allen <john.allen@....com>, "David S. Miller" <davem@...emloft.net>, Paolo Bonzini <pbonzini@...hat.com>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 1/4] crypto: ccp - Fix SEV_INIT error logging on init Currently only the firmware error code is printed. This is incomplete and also incorrect as error cases exists where the firmware is never called and therefore does not set an error code. This change zeros the firmware error code in case the call does not get that far and prints the return code for non firmware errors. Signed-off-by: Peter Gonda <pgonda@...gle.com> Acked-by: David Rientjes <rientjes@...gle.com> Cc: Tom Lendacky <thomas.lendacky@....com> Cc: Brijesh Singh <brijesh.singh@....com> Cc: Marc Orr <marcorr@...gle.com> Cc: Joerg Roedel <jroedel@...e.de> Cc: Herbert Xu <herbert@...dor.apana.org.au> Cc: David Rientjes <rientjes@...gle.com> Cc: John Allen <john.allen@....com> Cc: "David S. Miller" <davem@...emloft.net> Cc: Paolo Bonzini <pbonzini@...hat.com> ( Cc: linux-crypto@...r.kernel.org Cc: linux-kernel@...r.kernel.org --- drivers/crypto/ccp/sev-dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 2ecb0e1f65d8..ec89a82ba267 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -1065,7 +1065,7 @@ void sev_pci_init(void) { struct sev_device *sev = psp_master->sev_data; struct page *tmr_page; - int error, rc; + int error = 0, rc; if (!sev) return; @@ -1104,7 +1104,8 @@ void sev_pci_init(void) } if (rc) { - dev_err(sev->dev, "SEV: failed to INIT error %#x\n", error); + dev_err(sev->dev, "SEV: failed to INIT error %#x, rc %d\n", + error, rc); return; } -- 2.33.1.1089.g2158813163f-goog
Powered by blists - more mailing lists