linux-kernel - Re: [GIT PULL] MMC fixes for v5.15-rc8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9deee06-dd78-22fc-2d93-7c70e1f6522b@infradead.org>
Date:   Fri, 29 Oct 2021 14:47:24 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-mmc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>
Subject: Re: [GIT PULL] MMC fixes for v5.15-rc8

On 10/29/21 11:04 AM, Linus Torvalds wrote:
> On Fri, Oct 29, 2021 at 5:07 AM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>>
>>   - winbond: Silences build errors on M68K
> 
> I think this one is wrong.
> 
> I think the problem is that m68k declares "claim_dma_lock()" in the
> wrong header file. It's in <asm/floppy.h> instead of <asm/dma.h>
> 
> I'm somewhat surprised that this doesn't hit m68k in other places -
> there are other drivers that use that same ISA DMA interface.

I moved claim_dma_lock() and release_dma_lock() fro asm/floppy.h
to asm/dma.h (for arch/m68k/). I spent a few hours trying to fix
the resulting fallout.  Guess I'm just slow.

FWIW, the biggest problem I had was the variety of types of DMA that
M68K supports (once a driver includes <asm/dma.h>, things get messy).

> I've pulled this, but I hate how random that fix is.


-- 
~Randy