lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Oct 2021 15:03:24 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Charles Mirabile <cmirabil@...hat.com>, linux-kernel@...r.kernel.org Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-input@...r.kernel.org, Serge Schneider <serge@...pberrypi.org>, Stefan Wahren <stefan.wahren@...e.com>, Nicolas Saenz Julienne <nsaenzju@...hat.com>, linux-rpi-kernel@...ts.infradead.org, fedora-rpi@...glegroups.com, Mwesigwa Guma <mguma@...hat.com>, Joel Savitz <jsavitz@...hat.com> Subject: Re: [PATCH 2/5] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver On 10/29/21 2:55 PM, Charles Mirabile wrote: > This patch implements support for the joystick. > It supports left/right/up/down/enter and is > attached via i2c and a gpio pin for irq. > > Signed-off-by: Charles Mirabile <cmirabil@...hat.com> > Signed-off-by: Mwesigwa Guma <mguma@...hat.com> > Signed-off-by: Joel Savitz <jsavitz@...hat.com> > --- > drivers/input/joystick/Kconfig | 8 ++ > drivers/input/joystick/Makefile | 1 + > drivers/input/joystick/sensehat-joystick.c | 135 +++++++++++++++++++++ > 3 files changed, 144 insertions(+) > create mode 100644 drivers/input/joystick/sensehat-joystick.c > > diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig > index 3b23078bc7b5..d2f78353b74c 100644 > --- a/drivers/input/joystick/Kconfig > +++ b/drivers/input/joystick/Kconfig > @@ -399,4 +399,12 @@ config JOYSTICK_N64 > Say Y here if you want enable support for the four > built-in controller ports on the Nintendo 64 console. > > +config JOYSTICK_SENSEHAT > + tristate "Raspberry Pi Sense HAT joystick" > + depends on GPIOLIB && INPUT I think also: depends on I2C since this one: > + select MFD_SENSEHAT_CORE also depends on I2C and 'select' does not follow any dependency chains. Same comment applies to patch 3/5 for SENSEHAT_DISPLAY. > + > + help > + This is the joystick driver for the Raspberry Pi Sense HAT > + > endif -- ~Randy
Powered by blists - more mailing lists