linux-kernel - Re: [PATCH v2] crash_dump: remove duplicate include in crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 Oct 2021 17:28:30 +0800
From:   Baoquan He <bhe@...hat.com>
To:     cgel.zte@...il.com
Cc:     dyoung@...hat.com, kexec@...ts.infradead.org,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        rppt@...ux.ibm.com, vgoyal@...hat.com, ye.guojin@....com.cn,
        zealci@....com.cn
Subject: Re: [PATCH v2] crash_dump: remove duplicate include in crash_dump.h

On 10/20/21 at 09:06am, cgel.zte@...il.com wrote:
> From: Ye Guojin <ye.guojin@....com.cn>
> 
> In crash_dump.h, header file <linux/pgtable.h> is included twice. This
> duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
> after introduction of linux/pgtable.h") where the order of the header
> files is adjusted, while the old one was not removed.
> 
> Clean it up here.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Acked-by: Baoquan He <bhe@...hat.com>
> Signed-off-by: Ye Guojin <ye.guojin@....com.cn>

Thanks, add Andrew to CC.

> ---
> v2:
> - update the commit log
> ---
>  include/linux/crash_dump.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..b7b255b23b99 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
>  #include <linux/pgtable.h>
>  #include <uapi/linux/vmcore.h>
> 
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
>  /* For IS_ENABLED(CONFIG_CRASH_DUMP) */
>  #define ELFCORE_ADDR_MAX       (-1ULL)
>  #define ELFCORE_ADDR_ERR       (-2ULL)
> -- 
> 2.25.1
>