lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Oct 2021 17:31:07 +0800 From: Baoquan He <bhe@...hat.com> To: cgel.zte@...il.com Cc: dyoung@...hat.com, vgoyal@...hat.com, kexec@...ts.infradead.org, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, Changcheng Deng <deng.changcheng@....com.cn>, Zeal Robot <zealci@....com.cn> Subject: Re: [PATCH] crash_dump: fix boolreturn.cocci warning On 10/20/21 at 08:39am, cgel.zte@...il.com wrote: > From: Changcheng Deng <deng.changcheng@....com.cn> > > ./include/linux/crash_dump.h: 119: 50-51: WARNING: return of 0/1 in > function 'is_kdump_kernel' with return type bool > > Return statements in functions returning bool should use true/false > instead of 1/0. > > Reported-by: Zeal Robot <zealci@....com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn> Looks good to me, thanks. Acked-by: Baoquan He <bhe@...hat.com> > --- > include/linux/crash_dump.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h > index 0c547d866f1e..979c26176c1d 100644 > --- a/include/linux/crash_dump.h > +++ b/include/linux/crash_dump.h > @@ -116,7 +116,7 @@ extern void register_vmcore_cb(struct vmcore_cb *cb); > extern void unregister_vmcore_cb(struct vmcore_cb *cb); > > #else /* !CONFIG_CRASH_DUMP */ > -static inline bool is_kdump_kernel(void) { return 0; } > +static inline bool is_kdump_kernel(void) { return false; } > #endif /* CONFIG_CRASH_DUMP */ > > /* Device Dump information to be filled by drivers */ > -- > 2.25.1 >
Powered by blists - more mailing lists