linux-kernel - [PATCH] hid: playstation: add LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211029114044.1058958-1-arnd@kernel.org>
Date:   Fri, 29 Oct 2021 13:40:24 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Roderick Colenbrander <roderick@...kai.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Roderick Colenbrander <roderick.colenbrander@...y.com>,
        Barnabás Pőcze <pobrn@...tonmail.com>,
        "Daniel J. Ogorchock" <djogorchock@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] hid: playstation: add LEDS_CLASS dependency

From: Arnd Bergmann <arnd@...db.de>

The new LED support causes a link failure when the LEDS subsystem
is in a loadable module and the playstation HID driver is built-in:

ld.lld: error: undefined symbol: devm_led_classdev_multicolor_register_ext
>>> referenced by hid-playstation.c
>>>               hid/hid-playstation.o:(ps_lightbar_register) in archive drivers/built-in.a

Add a hard Kconfig dependency on LEDS_CLASS, but allow building with
the multicolor support disabled, as this is apparently meant as an
optional interface.

Fixes: 8c0ab553b072 ("HID: playstation: expose DualSense player LEDs through LED class.")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/hid/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a2c3d9b7bd01..cd10c398580e 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -899,6 +899,8 @@ config HID_PLANTRONICS
 config HID_PLAYSTATION
 	tristate "PlayStation HID Driver"
 	depends on HID
+	depends on LEDS_CLASS
+	depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
 	select CRC32
 	select POWER_SUPPLY
 	help
-- 
2.29.2