linux-kernel - Re: [PATCH -next] HID: nintendo: fix missing unlock on error in joycon_leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKvUva8WWhXXOjaDvssKTkQMq17pxDUHNQKjwfKvT1GQyvktgA@mail.gmail.com>
Date:   Fri, 29 Oct 2021 14:07:59 +0200
From:   Silvan Jegen <s.jegen@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     lkml <linux-kernel@...r.kernel.org>, linux-input@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        "Daniel J. Ogorchock" <djogorchock@...il.com>
Subject: Re: [PATCH -next] HID: nintendo: fix missing unlock on error in joycon_leds_create()

On Fri, Oct 29, 2021 at 5:04 AM Yang Yingliang <yangyingliang@...wei.com> wrote:
>
> Add the missing unlock before return from function joycon_leds_create()
> in the error handling case.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: c5e626769563 ("HID: nintendo: add player led support")
> Fixes: 697e5c7a34b0 ("HID: nintendo: add home led support")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/hid/hid-nintendo.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)

LGTM!

For what it's worth:

Reviewed-by: Silvan Jegen <s.jegen@...il.com>


Cheers,
Silvan