linux-kernel - Re: [PATCH] samples: fanotify: add CC_CAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tuh09f12.fsf@collabora.com>
Date:   Fri, 29 Oct 2021 09:44:25 -0300
From:   Gabriel Krisman Bertazi <krisman@...labora.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Jan Kara <jack@...e.cz>, Amir Goldstein <amir73il@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] samples: fanotify: add CC_CAN_LINK dependency

Arnd Bergmann <arnd@...nel.org> writes:

> From: Arnd Bergmann <arnd@...db.de>
>
> When using a cross tools that only works for kernels, the
> newn sample can end up with a link failure such as:
>
> /usr/bin/ld: unrecognised emulation mode: aarch64linux
> Supported emulations: elf_x86_64 elf32_x86_64 elf_i386 elf_iamcu elf_l1om elf_k1om i386pep i386pe
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> make[5]: *** [/git/arm-soc/scripts/Makefile.userprogs:28: samples/fanotify/fs-monitor] Error 1
>
> Add a Kconfig dependency, similar to the one we use for
> other samples.
>
> Fixes: 5451093081db ("samples: Add fs error monitoring example")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>


Hi Arnd,

This was reported by Guenter Roeck yesterday, I sent a patch for it
here:

https://lore.kernel.org/linux-fsdevel/87fsslasgz.fsf@collabora.com/


> ---
>  samples/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 147a16dafaf8..83f12c1e9ca6 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -122,7 +122,7 @@ config SAMPLE_CONNECTOR
>  
>  config SAMPLE_FANOTIFY_ERROR
>  	bool "Build fanotify error monitoring sample"
> -	depends on FANOTIFY
> +	depends on CC_CAN_LINK && FANOTIFY
>  	help
>  	  When enabled, this builds an example code that uses the
>  	  FAN_FS_ERROR fanotify mechanism to monitor filesystem

-- 
Gabriel Krisman Bertazi