lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Oct 2021 15:00:05 +0200 From: Emil Renner Berthing <kernel@...il.dk> To: Rob Herring <robh@...nel.org> Cc: linux-riscv <linux-riscv@...ts.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, linux-clk <linux-clk@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>, Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, Linus Walleij <linus.walleij@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jiri Slaby <jirislaby@...nel.org>, Maximilian Luz <luzmaximilian@...il.com>, Sagar Kadam <sagar.kadam@...ive.com>, Drew Fustini <drew@...gleboard.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, Michael Zhu <michael.zhu@...rfivetech.com>, Fu Wei <tekkamanninja@...il.com>, Anup Patel <anup.patel@....com>, Atish Patra <atish.patra@....com>, Matteo Croce <mcroce@...rosoft.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 11/16] dt-bindings: pinctrl: Add StarFive JH7100 bindings On Fri, 29 Oct 2021 at 03:50, Rob Herring <robh@...nel.org> wrote: > On Thu, Oct 21, 2021 at 07:42:18PM +0200, Emil Renner Berthing wrote: > > +patternProperties: > > + '-[0-9]*$': > > Can you make this more specific. As-is, '-' and 'foo-' are valid. > > > + type: object > > + patternProperties: > > + '-pins*$': > > So foo-pinsssssss is okay? Drop the '*' or use ? if you intend to > support 'foo-pin'. Ah, thanks. Both this and the pattern above was taken from pinctrl/mediatek,mt6779-pinctrl.yaml if anyone feels like fixing that too. I see now that '-[0-9]+$' and '-pins$' is more common. I'll just use that. > > + type: object > > + description: | > > + A pinctrl node should contain at least one subnode representing the > > + pinctrl groups available on the machine. Each subnode will list the > > + pins it needs, and how they should be configured, with regard to > > + muxer configuration, bias, input enable/disable, input schmitt > > + trigger enable/disable, slew-rate and drive strength. > > + $ref: "/schemas/pinctrl/pincfg-node.yaml" > > + > > + properties: > > + pins: > > + description: | > > + The list of pin identifiers that properties in the node apply to. > > + This should be set using either the PAD_GPIO or PAD_FUNC_SHARE > > + macro. Either this or "pinmux" has to be specified. > > + > > + pinmux: > > + description: | > > + The list of GPIO identifiers and their mux settings that > > + properties in the node apply to. This should be set using the > > + GPIOMUX macro. Either this or "pins" has to be specified. > > + > > + bias-disable: true > > + > > + bias-pull-up: > > + type: boolean > > Already has a type. Need to reference the common schema. Right, but the common schema specifies one of boolean or uint32. Is there a way to reference that, but still say that this binding supports only the boolean version?
Powered by blists - more mailing lists