linux-kernel - Re: [PATCH V7 8/9] trace/osnoise: Remove STACKTRACE ifdefs from inside functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211029090144.49f43936@gandalf.local.home>
Date:   Fri, 29 Oct 2021 09:01:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Daniel Bristot de Oliveira <bristot@...nel.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Tom Zanussi <zanussi@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-rt-users@...r.kernel.org, linux-trace-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V7 8/9] trace/osnoise: Remove STACKTRACE ifdefs from
 inside functions

On Fri, 29 Oct 2021 14:31:27 +0200
Daniel Bristot de Oliveira <bristot@...nel.org> wrote:

> > +	/*
> > +	 * 0 is disabled, so it will never be > than latency.
> > +	 */
> > +	if (osnoise_data.print_stack > latency)
> > +		return;  
> 
> Oops, I placed the comment, but forgot to place the check. This if should be:
> 
> if (!osnoise_data.print_stack || osnoise_data.print_stack > latency)
> 	return;

Or I could've had a V8!

  https://www.youtube.com/watch?v=qYo0lVVH2wU

-- Steve