linux-kernel - Re: [PATCH] wlwifi: Fix missing error code in iwl_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y26c2d9b.fsf@codeaurora.org>
Date:   Fri, 29 Oct 2021 16:04:32 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     luciano.coelho@...el.com, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wlwifi: Fix missing error code in iwl_pci_probe()

Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> writes:

> From: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'ret'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1376 iwl_pci_probe() warn:
> missing error code 'ret'.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: 1f171f4f1437 ("iwlwifi: Add support for getting rf id with blank otp")
> Signed-off-by: chongjiapeng <jiapeng.chong@...ux.alibaba.com>

The subject prefix should be "iwlwifi: ".

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches