linux-kernel - Re: [PATCH] [RFC] arm64: export this_cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com>
Date:   Fri, 29 Oct 2021 14:31:23 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Anshuman Khandual <anshuman.khandual@....com>
Cc:     Arnd Bergmann <arnd@...db.de>, Marc Zyngier <maz@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        David Brazdil <dbrazdil@...gle.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap

Hi Arnd

Thanks for the fix.

On 29/10/2021 12:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> It's now used in a coresight driver that can be a loadable module:
> 
> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
> 
> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>
Tested-by: Suzuki K Poulose <suzuki.poulose@....com>

Will, Catalin, Mathieu,

Do you have a preference on how this fix can be pulled in ? This may
be safe to go via coresight tree if it is not too late. Otherwise,
it could go via the arm64 tree.

Suzuki

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Not sure if we actually want this to be exported, this is my local
> workaround for the randconfig build bot.
> ---
>   arch/arm64/kernel/cpufeature.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index ecbdff795f5e..beccbcfa7391 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n)
>   
>   	return false;
>   }
> +EXPORT_SYMBOL(this_cpu_has_cap);
>   
>   /*
>    * This helper function is used in a narrow window when,
>