linux-kernel - Re: [BUG] About "io_uring: add more uring info to fdinfo for debug"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c6ec470-0985-2ee8-4cbd-1f9649c7b69c@kernel.dk>
Date:   Fri, 29 Oct 2021 11:56:53 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Hao Xu <haoxu@...ux.alibaba.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] About "io_uring: add more uring info to fdinfo for debug"

On 10/29/21 11:54 AM, Hao Xu wrote:
> Hi Jens,
> I was thinking that print all the entries including the unused ones
> would make the list very long(real product use hundreds or thousands
> while there may be just several useful sqes). And that may be confused,
> a example is: sq_array[0-999] = 0, we have only one sqe sqes[0] in use.
> then we'll print sqe[0] 1000 times, though we can get to know the real
> useful one by sq_head and tail info after calculation.
> And if only print the useful ones, exposing the original counters will
> make the loop condition a bit simpler than exposing the ring index(since
> the original counters depend on natural overflow) though we cannot do
> that now since realizing issues like what Eric reports.

We can revisit in the merge window, I wrote up the pull requests for
this branch (among others) already. The most important part was fixing
the looping to appropriately cap it.

-- 
Jens Axboe