lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 30 Oct 2021 12:32:42 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>, <corbet@....net>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 1/3] Docs: usb: update err() to pr_err() and replace
 __FILE__

On 29.10.2021 23:33, Sergey Shtylyov wrote:

[...]
>> update err() to pr_err() and replace __FILE__
>>
>> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
>> ---
>>   Documentation/driver-api/usb/writing_usb_driver.rst | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/driver-api/usb/writing_usb_driver.rst b/Documentation/driver-api/usb/writing_usb_driver.rst
>> index 2176297e5765..5c29e5bdbe88 100644
>> --- a/Documentation/driver-api/usb/writing_usb_driver.rst
>> +++ b/Documentation/driver-api/usb/writing_usb_driver.rst
>> @@ -91,8 +91,8 @@ usually in the driver's init function, as shown here::
>>   	    /* register this driver with the USB subsystem */
>>   	    result = usb_register(&skel_driver);
>>   	    if (result < 0) {
>> -		    err("usb_register failed for the "__FILE__ "driver."
>> -			"Error number %d", result);
>> +		    pr_err("usb_register failed for the %s driver. "
> 
>     Don't break up the kernel message like this. The current code is a bad example --
> high time to fix it. :-)
> 
>> +			   "Error number %d", skel_driver.name, result);

    Oh, and add `\n' at the end of message.

[...]

MBR, Sergey

Powered by blists - more mailing lists