linux-kernel - Re: [PATCH] bcache: remove unused struct member in cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abf21c4f-5bbb-a0bb-534a-3d2758b4a8d6@suse.de>
Date:   Sat, 30 Oct 2021 22:58:47 +0800
From:   Coly Li <colyli@...e.de>
To:     Lin Feng <linf@...gsu.com>
Cc:     linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: remove unused struct member in cache_stats

On 10/29/21 7:59 PM, Lin Feng wrote:
> Commit 1616a4c2ab1a80893b6890ae93da40a2b1d0c691
> ("bcache: remove bcache device self-defined readahead")
> remove stuffs for bcache self-defined readahead, but
> cache_readaheads field in cache_stats is leftout, remove it.
>
> Signed-off-by: Lin Feng <linf@...gsu.com>

Nice catch. I add it into my testing queue. Thanks.

Coly Li

> ---
>   drivers/md/bcache/stats.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
> index ca4f435f7216..b6bfea66c01f 100644
> --- a/drivers/md/bcache/stats.h
> +++ b/drivers/md/bcache/stats.h
> @@ -18,7 +18,6 @@ struct cache_stats {
>   	unsigned long cache_misses;
>   	unsigned long cache_bypass_hits;
>   	unsigned long cache_bypass_misses;
> -	unsigned long cache_readaheads;
>   	unsigned long cache_miss_collisions;
>   	unsigned long sectors_bypassed;
>