linux-kernel - Re: [PATCH 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cb5c303-5cba-cd3a-e73d-9e5535e3ab83@infradead.org>
Date:   Fri, 29 Oct 2021 17:00:33 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "LH.Kuo" <lhjeff911@...il.com>, ulf.hansson@...aro.org,
        p.zabel@...gutronix.de, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     dvorkin@...bo.com, qinjian@...lus1.com, wells.lu@...plus.com,
        "LH.Kuo" <lh.kuo@...plus.com>
Subject: Re: [PATCH 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

On 10/28/21 10:57 PM, LH.Kuo wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 95b3511..6f8bcd6 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -14,6 +14,16 @@ config MMC_DEBUG
>   	  added host drivers please don't invent their private macro for
>   	  debugging.
>   
> +config SP_SDV2
> +	tristate "Sunplus SP7021 SD/SDIO Controller"
> +	depends on SOC_SP7021
> +	default m
> +	help
> +	  This selects the Sunplus SP7021 SD/SDIO controller.
> +	  If you have a controller with this interface, say Y or M here..
> +
> +	  If unsure, say N.

Hi,
Does SOC_SP7021 require this driver to be built in order
to boot?
If not, please remove the "default m" line.

Also, several of your patches seem to have lots of line
changes to the MAINTAINERS file, but it looks like they
should not be part of your patch submission.

thanks.
-- 
~Randy