linux-kernel - Re: [PATCH v2] of/unittest: Disable new dtc node_name_vs_property_name and interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23f6c4f5-531d-56e1-1d68-305c37c01510@gmail.com>
Date:   Fri, 29 Oct 2021 20:45:27 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v2] of/unittest: Disable new dtc
 node_name_vs_property_name and interrupt_map warnings

On 10/28/21 8:12 PM, Frank Rowand wrote:
> Hi Rob,
> 
> On 10/28/21 8:04 AM, Rob Herring wrote:
>> The unittest dtbs have various intentional errors which cause warnings.
>> With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
>> some new checks: node_name_vs_property_name and interrupt_map warnings.
>> These warnings are also generated for static_base_1.dtb, so add
>> DTC_FLAGS for it.
>>
>> Note that the interrupt_map warnings only appear once interrupt_provider
>> warning is re-enabled globally.
>>
>> drivers/of/unittest-data/tests-interrupts.dtsi:32.26-35.6: Warning (interrupt_map): /testcase-data/interrupts/intmap1: Missing '#address-cells' in interrupt-map provider
>>
>> Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
>> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
>> Cc: Frank Rowand <frowand.list@...il.com>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>  drivers/of/unittest-data/Makefile | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
>> index a5d2d9254b2c..fbded24c608c 100644
>> --- a/drivers/of/unittest-data/Makefile
>> +++ b/drivers/of/unittest-data/Makefile
>> @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
>>  DTC_FLAGS_testcases += -@
>>  
>>  # suppress warnings about intentional errors
>> -DTC_FLAGS_testcases += -Wno-interrupts_property
>> +DTC_FLAGS_testcases += -Wno-interrupts_property \
>> +	-Wno-node_name_vs_property_name \
>> +	-Wno-interrupt_map
>>  
>>  # Apply overlays statically with fdtoverlay.  This is a build time test that
>>  # the overlays can be applied successfully by fdtoverlay.  This does not
>> @@ -82,6 +84,10 @@ apply_static_overlay_1 := overlay_0.dtbo \
>>  
>>  apply_static_overlay_2 := overlay.dtbo
>>  
>> +DTC_FLAGS_static_base_1 += -Wno-interrupts_property \
>> +	-Wno-node_name_vs_property_name \
>> +	-Wno-interrupt_map
>> +
>>  static_test_1-dtbs := static_base_1.dtb $(apply_static_overlay_1)
>>  static_test_2-dtbs := static_base_2.dtb $(apply_static_overlay_2)
>>  
>>
> 
> Thanks for splitting the DTC_FLAGS into per file values.
> 
> I dug into the unittest code that uses the dts node that causes the
> interrupt map warning and do not see any reason not to fix the dts
> so that the warning will not occur, instead of masking it with
> the DTC_FLAGS.  I just now submitted a patch to fix the .dtsi at
> 
>   https://lore.kernel.org/all/20211029005802.2047081-1-frowand.list@gmail.com/

That thread ended up deciding that the .dtsi should not be fixed to
avoid the warning (it was a deliberate error to allow a specific test),

so for the [v2] patch that started this thread:

Reviewed-by: Frank Rowand <frowand.list@...il.com>
Tested-by: Frank Rowand <frowand.list@...il.com>

> 
> -Frank
>