linux-kernel - Re: [PATCH v3 0/2] dmaengine: ti: k3-udma: Fix NULL pointer dereference error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87082448-0670-4fee-fc7b-8ead415180da@gmail.com>
Date:   Sat, 30 Oct 2021 09:45:54 +0300
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v3 0/2] dmaengine: ti: k3-udma: Fix NULL pointer
 dereference error

Hi Kishon,

On 29/10/2021 18:12, Kishon Vijay Abraham I wrote:
> NULL pointer de-reference error was observed when all the PCIe endpoint
> functions (22 function in J721E) request a DMA channel. The issue was
> specfically observed when using mem-to-mem copy.
> 
> Changes from v2:
> 1) Fix commit subject and commit log to mention bchan/rchan/tchan to NULL
>    suggested by Peter.

Looks good, however the second patch also fixes the rflow. It is
mentioned in the commit message itself.

I suppose the reason for a split is that the UDMA part
(rchan/tchan/rflow) could be backported as fix for older kernel since
the bchan came later with BCDMA/PKTDMA support?

Can you find a good Fixes tag for these?

> 
> Changes from v1:
> 1) Split the patch for BCDMA and PKTDMA separately
> 2) Fixed the return value of udma_get_rflow() to 0.
> 3) Removed the fixes tag as the patches does not directly apply to the
> commits.
> 
> v1 => https://lore.kernel.org/r/20210209090036.30832-1-kishon@ti.com
> v2 => https://lore.kernel.org/r/20211027055625.11150-1-kishon@ti.com
> 
> Kishon Vijay Abraham I (2):
>   dmaengine: ti: k3-udma: Set bchan to NULL if a channel request fail
>   dmaengine: ti: k3-udma: Set rchan/tchan to NULL if a channel request
>     fail

dmaengine: ti: k3-udma: Set r/tchan or rflow to NULL if request fail

would have bee a better subject line, if you feel you can send an update.

Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>


> 
>  drivers/dma/ti/k3-udma.c | 32 ++++++++++++++++++++++++++------
>  1 file changed, 26 insertions(+), 6 deletions(-)
> 

-- 
Péter