lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 Oct 2021 21:55:27 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>, linuxarm@...wei.com,
        mauro.chehab@...wei.com,
        Krzysztof Wilczyński <kw@...ux.com>,
        Binghui Wang <wangbinghui@...ilicon.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh@...nel.org>,
        Xiaowei Song <songxiaowei@...ilicon.com>,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v15 13/13] PCI: kirin: Allow removing the driver

On Thursday 21 October 2021 11:45:20 Mauro Carvalho Chehab wrote:
> Now that everything is in place at the poweroff sequence,
> this driver can use module_platform_driver(), which allows
> it to be removed.
> 
> Acked-by: Xiaowei Song <songxiaowei@...ilicon.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v15 00/13] at: https://lore.kernel.org/all/cover.1634812676.git.mchehab+huawei@kernel.org/
> 
>  drivers/pci/controller/dwc/pcie-kirin.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
> index fea4d717fff3..cdf568ea0f68 100644
> --- a/drivers/pci/controller/dwc/pcie-kirin.c
> +++ b/drivers/pci/controller/dwc/pcie-kirin.c
> @@ -827,7 +827,7 @@ static struct platform_driver kirin_pcie_driver = {
>  		.suppress_bind_attrs	= true,

Hello Mauro! I think that you should not set ".suppress_bind_attrs" to
"true" if you want to bind and unbind driver at runtime.

>  	},
>  };
> -builtin_platform_driver(kirin_pcie_driver);
> +module_platform_driver(kirin_pcie_driver);
>  
>  MODULE_DEVICE_TABLE(of, kirin_pcie_match);
>  MODULE_DESCRIPTION("PCIe host controller driver for Kirin Phone SoCs");
> -- 
> 2.31.1
> 

Powered by blists - more mailing lists