linux-kernel - Re: [PATCH 1/2] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163572120352.2079946.6960520137860452667.b4-ty@chromium.org>
Date:   Sun, 31 Oct 2021 16:01:41 -0700
From:   Benson Leung <bleung@...gle.com>
To:     linux-kernel@...r.kernel.org,
        Prashant Malani <pmalani@...omium.org>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC struct for
 features

Hi Prashant,

On Mon, 4 Oct 2021 10:07:09 -0700, Prashant Malani wrote:
> The Chrome EC's features are returned through an
> ec_response_get_features struct, but they are stored in an independent
> array. Although the two are effectively the same at present (2 unsigned
> 32 bit ints), there is the possibility that they could go out of sync.
> Avoid this by only using the EC struct to store the features.

Applied, thanks!

[1/2] platform/chrome: cros_ec_proto: Use EC struct for features
      commit: 7ff22787ba49c2e66dcec92f3e2b79ef6b6a0d71
[2/2] platform/chrome: cros_ec_proto: Use ec_command for check_features
      commit: 297d34e73d491a3edbd6e8c31d33ec90447a908b

Best regards,

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)