linux-kernel - Re: [PATCH v2] staging: r8188eu: avoid use of goto statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26a88652-0db7-6b85-565c-b7d002039cd9@gmail.com>
Date:   Sun, 31 Oct 2021 15:01:21 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, saurav.girepunje@...mail.com
Subject: Re: [PATCH v2] staging: r8188eu: avoid use of goto statement



On 26/10/21 10:16 pm, Greg KH wrote:
> On Mon, Oct 25, 2021 at 08:06:00PM +0530, Saurav Girepunje wrote:
>> Remove the goto statement from _rtw_init_cmd_priv(). In this function
>> goto statement can be replace by return statement. By replacing the
>> goto statement with return statement local variable "res" is also not
>> required. As on goto label exit, function only return it is not
>> performing any cleanup. Avoiding goto statement will simplify the function.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
>> ---
>>
>> ChangeLog V2:
>>
>> 	-Add space after line end on changelog.
>> 	-Remove addition blank link after the local variable res
>> 	 as per the coding guidelines for linux kernel.
>>
> 
> This does not apply to my tree, please rebase and resubmit.
> 
> thanks,
> 
> greg k-h
> 

OK,

Regards,
Saurav