linux-kernel - Re: [PATCH v1 3/4] ASoC: dt-bindings: nxp, tfa989x: Add rcv-gpios property for tfa9897

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 31 Oct 2021 10:35:15 +0100
From:   Vincent Knecht <vincent.knecht@...loo.org>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        stephan@...hold.net, linux-kernel@...r.kernel.org, tiwai@...e.com,
        lgirdwood@...il.com, broonie@...nel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v1 3/4] ASoC: dt-bindings: nxp, tfa989x: Add rcv-gpios
 property for tfa9897

Le jeudi 28 octobre 2021 à 21:13 -0500, Rob Herring a écrit :
> On Sun, Oct 24, 2021 at 10:58:39AM +0200, Vincent Knecht wrote:
> > Add optional rcv-gpios property specific to tfa9897 receiver mode.
> > 
> > Signed-off-by: Vincent Knecht <vincent.knecht@...loo.org>
> > ---
> >  .../devicetree/bindings/sound/nxp,tfa989x.yaml         | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> > b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> > index 7667471be1e4..a9e15baedafd 100644
> > --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> > +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> > @@ -12,6 +12,16 @@ maintainers:
> >  allOf:
> >    - $ref: name-prefix.yaml#
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: nxp,tfa9897
> > +    then:
> > +      properties:
> > +        rcv-gpios:
> > +          description: optional GPIO to be asserted when receiver mode is enabled.
> 
> Did you test this works? 
> 
> You have to define the property outside the if/then schema at the top 
> level. Then use an if/then schema to restrict it (rcv-gpios: false).

Sorry, I only tested validation with dt_binding_check.

I'll send another version later today with
if:
  not:
    properties:
      compatible:
        const: nxp,tfa9897
then:
  properties:
    rcv-gpios: false
and a tfa9897 example section, which passes the check and fails
if rcv-gpio is added to tfa9895.

Thank you