linux-kernel - Re: [PATCH v2] pinctrl: ralink: include 'ralink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 31 Oct 2021 15:08:13 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stable <stable@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>
Subject: Re: [PATCH v2] pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c'

On Sun, Oct 31, 2021 at 8:41 AM Sergio Paracuellos
<sergio.paracuellos@...il.com> wrote:
>
> mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN
> declared in ralink_regs.h.
>
> Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")
> Cc: stable@...r.kernel.org
> Cc: linus.walleij@...aro.org
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>

Tag blocks mustn't have blank lines.

...

> +#include <asm/mach-ralink/ralink_regs.h>
>  #include <asm/mach-ralink/mt7620.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>

Actually the rule of thumb is to start from more generic definitions /
inclusions to more particular. Thus, asm/* usually goes after linux/*.
Any Specific reason why here is not the case?

-- 
With Best Regards,
Andy Shevchenko