linux-kernel - Re: [PATCH] tags: add a space regex to DECLARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17bd93d6d81cf267e7d0c63b533cc23f@kernel.org>
Date:   Mon, 01 Nov 2021 16:53:52 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Zhaoyu Liu <zackary.liu.pro@...il.com>
Cc:     masahiroy@...nel.org, ripxorip@...il.com,
        gregkh@...uxfoundation.org, matthieu.baerts@...sares.net,
        mpe@...erman.id.au, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tags: add a space regex to DECLARE_BITMAP

On 2021-11-01 15:59, Zhaoyu Liu wrote:
> When "make tags", it prompts a warning:
> 
>     ctags: Warning: drivers/pci/controller/pcie-apple.c:150:
>     null expansion of name pattern "\1"
> 
> The reason is that there is an indentation beside arguments of
> DECLARE_BITMAP, but it can parsed normally by gtags. It's also
> allowed in C.
> 
> So fix this regex temporarily, and wait for better solutions
> applied to other regexs.
> 
> Reviewed-by: Marc Zyngier <maz@...nel.org>

No, please! I never reviewed this patch. I *suggested*i it [1]
as a potential avenue for improvement.

You cannot put this tag on a patch unless someone explicitly
grants it.

> Signed-off-by: Zhaoyu Liu <zackary.liu.pro@...il.com>
> ---
>  scripts/tags.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index b24bfaec6290..7e5f19391f20 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -186,7 +186,7 @@ regex_c=(
>  
> 	'/\<DEFINE_\(RT_MUTEX\|MUTEX\|SEMAPHORE\|SPINLOCK\)(\([[:alnum:]_]*\)/\2/v/'
>  	'/\<DEFINE_\(RAW_SPINLOCK\|RWLOCK\|SEQLOCK\)(\([[:alnum:]_]*\)/\2/v/'
>  	'/\<DECLARE_\(RWSEM\|COMPLETION\)(\([[:alnum:]_]\+\)/\2/v/'
> -	'/\<DECLARE_BITMAP(\([[:alnum:]_]*\)/\1/v/'
> +	'/\<DECLARE_BITMAP([[:space:]]*\([[:alnum:]_]*\)/\1/v/'
>  	'/\(^\|\s\)\(\|L\|H\)LIST_HEAD(\([[:alnum:]_]*\)/\3/v/'
>  	'/\(^\|\s\)RADIX_TREE(\([[:alnum:]_]*\)/\2/v/'
>  	'/\<DEFINE_PER_CPU([^,]*, *\([[:alnum:]_]*\)/\1/v/'

More importantly, and assuming this is the correct approach,
why should we limit this to DECLARE_BITMAP()?

Thanks,

         M.

[1] https://lore.kernel.org/r/878ry89nfp.wl-maz@kernel.org
-- 
Jazz is not dead. It just smells funny...