linux-kernel - Re: [RFC 02/16] KVM: selftests: add hooks for managing encrypted guest memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL715WK2q0yfLJ-7AQ5stY5h6NfC7PXO7kunHmw=Rp_JMt7CVQ@mail.gmail.com>
Date:   Mon, 1 Nov 2021 10:44:44 -0700
From:   Mingwei Zhang <mizhang@...gle.com>
To:     Michael Roth <Michael.Roth@....com>
Cc:     linux-kselftest@...r.kernel.org, kvm <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Nathan Tempelman <natet@...gle.com>,
        Marc Orr <marcorr@...gle.com>,
        Steve Rutherford <srutherford@...gle.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Brijesh Singh <brijesh.singh@....com>,
        Tom Lendacky <Thomas.Lendacky@....com>,
        Varad Gautam <varad.gautam@...e.com>,
        Shuah Khan <shuah@...nel.org>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Ricardo Koller <ricarkol@...gle.com>,
        Jim Mattson <jmattson@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>
Subject: Re: [RFC 02/16] KVM: selftests: add hooks for managing encrypted
 guest memory

On Tue, Oct 26, 2021 at 8:48 AM Mingwei Zhang <mizhang@...gle.com> wrote:
>
> On Wed, Oct 20, 2021 at 8:46 PM Michael Roth <michael.roth@....com> wrote:
> >
> > On Mon, Oct 18, 2021 at 08:00:00AM -0700, Mingwei Zhang wrote:
> > > > +void vm_set_memory_encryption(struct kvm_vm *vm, bool enc_by_default, bool has_enc_bit,
> > > > +                             uint8_t enc_bit)
> > > > +{
> > > > +       vm->memcrypt.enabled = true;
> > > > +       vm->memcrypt.enc_by_default = enc_by_default;
> > > > +       vm->memcrypt.has_enc_bit = has_enc_bit;
> > > > +       vm->memcrypt.enc_bit = enc_bit;
> > > > +}
> > > > +
> > > > +struct sparsebit *
> > > > +vm_get_encrypted_phy_pages(struct kvm_vm *vm, int slot, vm_paddr_t *gpa_start,
> > > > +                          uint64_t *size)
> > > > +{
> > > > +       struct userspace_mem_region *region;
> > > > +       struct sparsebit *encrypted_phy_pages;
> > > > +
> > > > +       if (!vm->memcrypt.enabled)
> > > > +               return NULL;
> > > > +
> > > > +       region = memslot2region(vm, slot);
> > > > +       if (!region)
> > > > +               return NULL;
> > > > +
> > > > +       encrypted_phy_pages = sparsebit_alloc();
> > > > +       sparsebit_copy(encrypted_phy_pages, region->encrypted_phy_pages);
> > >
> > > Do we have to make a copy for the sparsebit? Why not just return the
> > > pointer? By looking at your subsequent patches, I find that this data
> > > structure seems to be just read-only?
> >
> > Yes, it's only intended to be used for read access. But I'll if I can
> > enforce that without the need to use a copy.
> >
>
> Understood. Thanks for the clarification. Yeah, I think both making a
> copy and returning a const pointer should work. I will leave that to
> you then.
>
> Thanks.
> -Mingwei

Reviewed-by: Mingwei Zhang <mizhang@...gle.com>

Thanks.
-Mingwei