lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Nov 2021 12:48:56 -0700 From: Yang Shi <shy828301@...il.com> To: gregkh@...uxfoundation.org, naoya.horiguchi@....com, hughd@...gle.com, kirill.shutemov@...ux.intel.com, willy@...radead.org, osalvador@...e.de, peterx@...hat.com, akpm@...ux-foundation.org Cc: shy828301@...il.com, stable@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream. When handling THP hwpoison checked if the THP is in allocation or free stage since hwpoison may mistreat it as hugetlb page. After commit 415c64c1453a ("mm/memory-failure: split thp earlier in memory error handling") the problem has been fixed, so this check is no longer needed. Remove it. The side effect of the removal is hwpoison may report unsplit THP instead of unknown error for shmem THP. It seems not like a big deal. The following patch "mm: filemap: check if THP has hwpoisoned subpage for PMD page fault" depends on this, which fixes shmem THP with hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be backported to -stable as well. Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com Signed-off-by: Yang Shi <shy828301@...il.com> Suggested-by: Naoya Horiguchi <naoya.horiguchi@....com> Acked-by: Naoya Horiguchi <naoya.horiguchi@....com> Cc: Hugh Dickins <hughd@...gle.com> Cc: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> Cc: Matthew Wilcox <willy@...radead.org> Cc: Oscar Salvador <osalvador@...e.de> Cc: Peter Xu <peterx@...hat.com> Cc: <stable@...r.kernel.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org> --- mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch depends on this one. mm/memory-failure.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 5d880d4eb9a2..bf601283fcf3 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -956,20 +956,6 @@ static int get_hwpoison_page(struct page *page) { struct page *head = compound_head(page); - if (!PageHuge(head) && PageTransHuge(head)) { - /* - * Non anonymous thp exists only in allocation/free time. We - * can't handle such a case correctly, so let's give it up. - * This should be better than triggering BUG_ON when kernel - * tries to touch the "partially handled" page. - */ - if (!PageAnon(head)) { - pr_err("Memory failure: %#lx: non anonymous thp\n", - page_to_pfn(page)); - return 0; - } - } - if (get_page_unless_zero(head)) { if (head == compound_head(page)) return 1; -- 2.26.2
Powered by blists - more mailing lists