linux-kernel - Re: linux-next: manual merge of the tip tree with the gfs2 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Nov 2021 10:57:20 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Steven Whitehouse <swhiteho@...hat.com>,
        Bob Peterson <rpeterso@...hat.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        Borislav Petkov <bp@...e.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: manual merge of the tip tree with the gfs2 tree

Hi all,

On Fri, 15 Oct 2021 15:04:20 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Today's linux-next merge of the tip tree got a conflict in:
> 
>   arch/x86/kernel/fpu/signal.c
> 
> between commit:
> 
>   4303543bac16 ("gup: Turn fault_in_pages_{readable,writeable} into fault_in_{readable,writeable}")
> 
> from the gfs2 tree and commits:
> 
>   fcfb7163329c ("x86/fpu/signal: Move xstate clearing out of copy_fpregs_to_sigframe()")
>   a2a8fd9a3efd ("x86/fpu/signal: Change return code of restore_fpregs_from_user() to boolean")
> 
> from the tip tree.
> 
> I fixed it up (I used the latter version - see below) and can carry the
> fix as necessary. This is now fixed as far as linux-next is concerned,
> but any non trivial conflicts should be mentioned to your upstream
> maintainer when your tree is submitted for merging.  You may also want
> to consider cooperating with the maintainer of the conflicting tree to
> minimise any particularly complex conflicts.
> 
> diff --cc arch/x86/kernel/fpu/signal.c
> index 164c96434704,37dbfed29d75..000000000000
> --- a/arch/x86/kernel/fpu/signal.c
> +++ b/arch/x86/kernel/fpu/signal.c
> @@@ -275,12 -283,12 +283,12 @@@ retry
>   		fpregs_unlock();
>   
>   		/* Try to handle #PF, but anything else is fatal. */
> - 		if (ret != -EFAULT)
> - 			return -EINVAL;
> + 		if (ret != X86_TRAP_PF)
> + 			return false;
>   
>  -		if (!fault_in_pages_readable(buf, size))
>  +		if (!fault_in_readable(buf, size))
>   			goto retry;
> - 		return -EFAULT;
> + 		return false;
>   	}
>   
>   	/*

This is now a conflict between Linus' tree and the gfs2 tree.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped