linux-kernel - Re: [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Nov 2021 08:20:33 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     David Heidelberg <david@...t.cz>
Cc:     Oleksij Rempel <linux@...pel-privat.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Anson Huang <Anson.Huang@....com>,
        ~okias/devicetree@...ts.sr.ht, Rob Herring <robh@...nel.org>,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: imx: hardware do not restrict
 clock-frequency to only 100 and 400 kHz

On Fri, Oct 29, 2021 at 04:11:33PM +0200, David Heidelberg wrote:
> clock-frequency is only restricted by the upper limit of 400 kHz.
> 
> Found with:
> $ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
> ...
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@...20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
> 	From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> ...
> 
> Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
> Signed-off-by: David Heidelberg <david@...t.cz>

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!

> ---
>  Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> index 3592d49235e0..c167958ae2a9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> @@ -57,7 +57,9 @@ properties:
>      const: ipg
>  
>    clock-frequency:
> -    enum: [ 100000, 400000 ]
> +    minimum: 1
> +    default: 100000
> +    maximum: 400000
>  
>    dmas:
>      items:
> -- 
> 2.33.0
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |